-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Inactive Reconciler Performance when --lookup-balance-by-block=false #66
Merged
patrick-ogrady
merged 9 commits into
master
from
patrick/inactive-reconciler-improvements
Jul 15, 2020
Merged
Improve Inactive Reconciler Performance when --lookup-balance-by-block=false #66
patrick-ogrady
merged 9 commits into
master
from
patrick/inactive-reconciler-improvements
Jul 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2540
💛 - Coveralls |
37e2236
to
0cc8cda
Compare
ff0c8ad
to
48272b8
Compare
c249946
to
745b911
Compare
juliankoh
approved these changes
Jul 15, 2020
Review Error for juliankoh @ 2020-07-15 11:03:36 UTC |
juliankoh
approved these changes
Jul 15, 2020
Review Error for juliankoh @ 2020-07-15 11:04:24 UTC |
juliankoh
approved these changes
Jul 15, 2020
This was referenced Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #65
Solution
inactiveAccountQueue
even if we are far behind tipinactiveAccountQueue
(could occur if accountsseenAccounts
check on each block) fromO(n)
to~O(1)
(caused reconciler to get much slower as more accounts seen).inactive reconciler
respects thehighWaterMark
(so useless queries are not performed during syncing).~O(1)
time now.Other Thoughts
We could further optimize the
reconciler
to cache balances it retrieved when behind tip so that reconciliation could begin before making it to tip. This would require some careful thinking and testing and should be attempted in another PR.